-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addressing small nits for channel capability migrations #2258
Merged
chatton
merged 5 commits into
main
from
cian/issue#2244-channel-capability-migration-nits
Sep 13, 2022
Merged
Addressing small nits for channel capability migrations #2258
chatton
merged 5 commits into
main
from
cian/issue#2244-channel-capability-migration-nits
Sep 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
requested review from
seantking,
colin-axner,
AdityaSripal and
damiannolan
as code owners
September 9, 2022 13:08
damiannolan
approved these changes
Sep 9, 2022
Codecov Report
@@ Coverage Diff @@
## main #2258 +/- ##
=======================================
Coverage 79.51% 79.51%
=======================================
Files 175 175
Lines 12075 12075
=======================================
Hits 9601 9601
Misses 2049 2049
Partials 425 425
|
colin-axner
approved these changes
Sep 12, 2022
chatton
deleted the
cian/issue#2244-channel-capability-migration-nits
branch
September 13, 2022 07:36
mergify bot
pushed a commit
that referenced
this pull request
Sep 13, 2022
(cherry picked from commit c2ce323)
crodriguezvega
added a commit
that referenced
this pull request
Sep 16, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #2244
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes