Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing small nits for channel capability migrations #2258

Merged
merged 5 commits into from
Sep 13, 2022

Conversation

chatton
Copy link
Contributor

@chatton chatton commented Sep 9, 2022

Description

closes: #2244


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@chatton chatton marked this pull request as ready for review September 9, 2022 13:08
@codecov-commenter
Copy link

Codecov Report

Merging #2258 (efb5fae) into main (a4be561) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2258   +/-   ##
=======================================
  Coverage   79.51%   79.51%           
=======================================
  Files         175      175           
  Lines       12075    12075           
=======================================
  Hits         9601     9601           
  Misses       2049     2049           
  Partials      425      425           
Impacted Files Coverage Δ
...in-accounts/controller/migrations/v5/migrations.go 89.65% <100.00%> (ø)

@chatton chatton enabled auto-merge (squash) September 13, 2022 07:04
@chatton chatton merged commit c2ce323 into main Sep 13, 2022
@chatton chatton deleted the cian/issue#2244-channel-capability-migration-nits branch September 13, 2022 07:36
mergify bot pushed a commit that referenced this pull request Sep 13, 2022
crodriguezvega added a commit that referenced this pull request Sep 16, 2022
#2278)

(cherry picked from commit c2ce323)

Co-authored-by: Cian Hatton <cian@interchain.io>
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Channel capability migration nits
4 participants