Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: revert changing error code #2352

Merged
merged 2 commits into from
Sep 23, 2022
Merged

chore: revert changing error code #2352

merged 2 commits into from
Sep 23, 2022

Conversation

charleenfei
Copy link
Contributor

Description

closes: #2225

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

damiannolan
damiannolan approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

crodriguezvega
crodriguezvega approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @charleenfei!

@charleenfei charleenfei merged commit 0af2686 into main Sep 23, 2022
@charleenfei charleenfei deleted the charly/revert_error_code branch September 23, 2022 10:29
mergify bot pushed a commit that referenced this pull request Sep 23, 2022
@charleenfei @mergify
chore: revert changing error code (#2352)
de3800c 
(cherry picked from commit 0af2686)
@mergify mergify bot mentioned this pull request Sep 23, 2022
Merged
damiannolan pushed a commit that referenced this pull request Sep 26, 2022
@mergify @charleenfei
chore: revert changing error code (#2352) (#2372)
8e5b353 
(cherry picked from commit 0af2686)

Co-authored-by: Charly <charly@interchain.berlin>
@chatton chatton mentioned this pull request Nov 7, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crodriguezvega crodriguezvega crodriguezvega approved these changes

@damiannolan damiannolan damiannolan approved these changes

@seantking seantking Awaiting requested review from seantking

@colin-axner colin-axner Awaiting requested review from colin-axner

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revert changing controller error from 2 to 1
3 participants
@charleenfei @damiannolan @crodriguezvega