Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new Constructor function that creates transfer message with Metadata #2412

Closed
AdityaSripal opened this issue Sep 27, 2022 · 4 comments
Assignees
Milestone

Comments

@AdityaSripal
Copy link
Member

AdityaSripal commented Sep 27, 2022

Create a new constructor function that takes in metadata that gets included in the packet data struct. This should not replace the existing method to maintain backwards compatibility

@crodriguezvega crodriguezvega added this to the v6.0.0 milestone Sep 27, 2022
@colin-axner
Copy link
Contributor

colin-axner commented Sep 28, 2022

I'd prefer to break API when merging into v6. We could create a new constructor, but I don't see a reason to maintain it long term, think it'd just add confusion. I think it makes more sense for pre v6 versions to expliticly create their packet data with:

packetData := transfertypes.FungibleTokenPacketData{
    ...
    Memo: memo, 
}

@nicolaslara
Copy link
Contributor

Do we know which versions we're targeting for the backports?

@crodriguezvega
Copy link
Contributor

Do we know which versions we're targeting for the backports?

v2.5.x, v3.4.x, v4.2.x and v5.1.x.

@AdityaSripal AdityaSripal changed the title Create a new Constructor function that creates transfer message with memo Create a new Constructor function that creates transfer message with Metadata Sep 29, 2022
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Oct 3, 2022
@crodriguezvega crodriguezvega moved this from Todo to In progress in ibc-go Oct 3, 2022
@colin-axner
Copy link
Contributor

closed by #2305

Repository owner moved this from In progress to Done in ibc-go Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants