Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional Metadata into the cli and rpc endpoints for MsgTransfer #2413

Closed
AdityaSripal opened this issue Sep 27, 2022 · 2 comments
Closed

Add optional Metadata into the cli and rpc endpoints for MsgTransfer #2413

AdityaSripal opened this issue Sep 27, 2022 · 2 comments
Assignees
@nicolaslara
Labels
20-transfer
Milestone
v6.0.0

Comments

@AdityaSripal
Copy link
Member

AdityaSripal commented Sep 27, 2022 •
edited
Loading

The metadata field should be made optional (e.g. flag in the CLI) so that we maintain backwards compatibility
@crodriguezvega crodriguezvega added this to the v6.0.0 milestone Sep 27, 2022
@nicolaslara
Copy link
Contributor

I can work on this. Should we converge on a name for this? (memo vs metadata).

I think having metadata be generic and the memo be one type of metadata makes sense (i.e.: metadata: {memo: "..."} )

@AdityaSripal AdityaSripal changed the title Add optional memo into the cli and rpc endpoints for MsgTransfer Add optional Metadata into the cli and rpc endpoints for MsgTransfer Sep 29, 2022
@crodriguezvega crodriguezvega moved this to In progress in ibc-go Oct 3, 2022
@colin-axner
Copy link
Contributor

closed by #2305

Repository owner moved this from In progress to Done in ibc-go Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolaslara nicolaslara

Labels
20-transfer
Projects
ibc-go
Archived in project
Milestone
v6.0.0
Development

No branches or pull requests
4 participants
@nicolaslara @crodriguezvega @AdityaSripal @colin-axner