Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GetSender and GetReceiver methods to Packet interface #2454

Closed
3 tasks
AdityaSripal opened this issue Sep 30, 2022 · 3 comments
Closed
3 tasks

Add GetSender and GetReceiver methods to Packet interface #2454

AdityaSripal opened this issue Sep 30, 2022 · 3 comments
Labels
good first issue Good for newcomers needs discussion Issues that need discussion before they can be worked on

Comments

@AdityaSripal
Copy link
Member

AdityaSripal commented Sep 30, 2022 •
edited
Loading

Needed for ADR-8

  • Add GetSender and GetReceiver methods to packet interface
  • Transfer will return the packet.Sender and packet.Receiver respectively
  • ICA will return the ICA controller account (on controller chain!!) for packet.GetSender() and returns empty string for packet.GetReceiver()
@AdityaSripal AdityaSripal added the good first issue Good for newcomers label Sep 30, 2022
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Oct 3, 2022
@crodriguezvega crodriguezvega added this to the v6.0.0 milestone Oct 3, 2022
@crodriguezvega crodriguezvega moved this from Todo to On hold in ibc-go Oct 3, 2022
@alizahidraja
Copy link
Contributor

Can take up this and #2455

@crodriguezvega
Copy link
Contributor

Hi @alizahidraja, thanks for offering. Yesterday @colin-axner had some questions about this issue, so it might be good to clarify those first with @AdityaSripal. I will add the label needs discussion for now.

@crodriguezvega crodriguezvega added the needs discussion Issues that need discussion before they can be worked on label Oct 4, 2022
@colin-axner
Copy link
Contributor

For future reference, it might be nice to open ADR issues after the ADR has been merged to avoid opening issues that may not be necessary

@crodriguezvega crodriguezvega removed this from the v6.0.0 milestone Oct 24, 2022
Repository owner moved this from On hold to Done in ibc-go Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers needs discussion Issues that need discussion before they can be worked on
Projects
ibc-go
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@crodriguezvega @AdityaSripal @colin-axner @alizahidraja