Persist channel state before calling OnChanOpenAck

[alpe]

Summary

We have this code smell in x/wasm/ibc.go for backwards compatibility . Can you set the channel state before OnChanOpenAck is called (as it was in the past) ? It probably does not make a big difference for you but we need the channel active for the contract. The ack callback may trigger the first IBC package to be sent.

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged/assigned

[crodriguezvega]

Thanks for opening this issue, @alpe! If I understand it correctly, your request is to move this line before this one, right?

How much are you blocked on this? Would you require this change for the upgrade of wasmd to SDK 0.47?

[alpe]

, your request is to move this line before this one, right?

Correct 👍

How much are you blocked on this?

We are not blocked by this as we persist the channel state ourself. But that is a hack that I would like to see removed in our code as soon as possible.

Would you require this change for the upgrade of wasmd to SDK 0.47?

This is unrelated to the SDK upgrade. A backport to v4.2 would be great to so that we can apply this early

[crodriguezvega]

All right. Thanks for the clarifications!

[damiannolan]

afaik we made these changes just for consistency when adding the application version negotiation return values for OnChanOpenInit and OnChanOpenTry.
I think it should be fine to change ChanOpenAck to write the channel before the app cbs are invoked, but we should probably do the same for ChanOpenConfirm also. cc @AdityaSripal

[AdityaSripal]

afaik we made these changes just for consistency when adding the application version negotiation return values for OnChanOpenInit and OnChanOpenTry.
I think it should be fine to change ChanOpenAck to write the channel before the app cbs are invoked, but we should probably do the same for ChanOpenConfirm also. cc @AdityaSripal

Yes that is correct