Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests for 09-localhost #3033

Closed
3 of 6 tasks
Tracked by #3034
damiannolan opened this issue Jan 20, 2023 · 4 comments
Closed
3 of 6 tasks
Tracked by #3034

Add e2e tests for 09-localhost #3033

damiannolan opened this issue Jan 20, 2023 · 4 comments
Assignees
Milestone

Comments

@damiannolan
Copy link
Contributor

damiannolan commented Jan 20, 2023

Summary

E2E tests should be added for the 09-localhost client.

  • E2E test using transfer module on sentinel localhost connection.
  • E2E test using 27-interchain-accounts module on sentinel localhost connection.
  • E2E upgrade test for running chain upgrade migration handler to enable localhost client

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added this to the v7.1.0 milestone Jan 20, 2023
@damiannolan damiannolan moved this to Todo in ibc-go Jan 20, 2023
@chatton chatton self-assigned this Jan 25, 2023
@chatton chatton moved this from Todo to In progress in ibc-go Jan 25, 2023
@chatton chatton moved this from In progress to On hold in ibc-go Feb 2, 2023
@crodriguezvega crodriguezvega moved this from On hold to Todo in ibc-go Feb 6, 2023
@damiannolan damiannolan self-assigned this Feb 7, 2023
@damiannolan damiannolan moved this from Todo to In progress in ibc-go Feb 7, 2023
@damiannolan damiannolan moved this from In progress to On hold in ibc-go Feb 10, 2023
@damiannolan damiannolan moved this from On hold to In review in ibc-go Feb 14, 2023
@colin-axner
Copy link
Contributor

Is this issue completed?

@damiannolan
Copy link
Contributor Author

Need to add a basic upgrade test that runs automatic migrations.

We can't actually reuse "normal upgrade" in simapp in its current state. For example, if we upgrade from v7.0.0 -> v7.1.0, then "normal upgrade" is already a registered upgrade handler and on x/upgrade begin block we fail here. We basically need to register the default upgrade handler against a new name in the v7.1.0 binary.

@colin-axner
Copy link
Contributor

That makes sense. Essentially each upgrade/bin needs a unique name?

@damiannolan
Copy link
Contributor Author

Yeah, we can reuse CreateDefaultUpgradeHandler but we need a unique name for each version increment.

@github-project-automation github-project-automation bot moved this from In review to Todo in ibc-go Feb 21, 2023
@damiannolan damiannolan moved this from Todo to Done in ibc-go Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants