-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Malicious relayer attack preventing correct tying of connection ends #32
Comments
Without adding spec level constraints on identifiers, this would be the simplest solution. |
Has this been fixed with the auto-generated identifier changes? cc @cwgoes |
Yes, this is no longer applicable, I believe. |
faddat
referenced
this issue
in notional-labs/ibc-go
Feb 23, 2022
Use json.RawMessage to displays bytes nicer in json format
faddat
referenced
this issue
in notional-labs/ibc-go
Mar 1, 2022
* Update to lastest ibc-alpha * update to latest cosmos-sdk@ibc-alpha * Add indentifier validation from ics24 and use it throughout codebase
faddat
referenced
this issue
in notional-labs/ibc-go
Mar 1, 2022
* Fix height issue in relay packets * Remove unnecessary context call * WIP refactor * refactor cont. * dev-env working * I think this is working? Co-authored-by: jtieri <37750742+jtieri@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Summarizing here discussion with @milosevic and Ilina about this and also @ebuchman on cosmos/cosmos-sdk#7870:
A connection or channel will never reach
Open
state if there is a mismatch in the identifiers. It is very simple to write a relayer that watches theOpenInit
events fromA
and immediately send aMsgOpenInit
toB
with mismatched connection ids, blocking forever the handshake on the connection/ channel.It may be that the “correct” relayer that would guarantee that the handshake finishes would have to do something like:
MsgOpenInit
without specifying the counterparty connection id (this is allowed now in order to support flexible id selection)OpenTry
(i.e. tie the two connection ends with a message that carries proofs)So maybe one solution is to not allow the
MsgOpenInit
with counterparty connection_id specified.This should be looked at more closely and determine the best solution.
For Admin Use
The text was updated successfully, but these errors were encountered: