Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling of channel upgrades to ADR 008 #3318

Closed
3 tasks
colin-axner opened this issue Mar 22, 2023 · 1 comment
Closed
3 tasks

Add handling of channel upgrades to ADR 008 #3318

colin-axner opened this issue Mar 22, 2023 · 1 comment
Assignees
Labels
docs Improvements or additions to documentation

Comments

@colin-axner
Copy link
Contributor

Summary

Once ibc-go supports upgrading channels, logic on how this should be handled/supported by ADR 008 implementations should be added to the ADR itself.

see comment


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added the icebox Issues that we will not address for the time being label Mar 22, 2023
@crodriguezvega crodriguezvega added docs Improvements or additions to documentation and removed icebox Issues that we will not address for the time being labels Jan 30, 2024
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Jan 30, 2024
@crodriguezvega crodriguezvega self-assigned this Mar 4, 2024
@crodriguezvega
Copy link
Contributor

I think we can close this issue, because when it was created the ADR had an IBCActor interface with channel handshake callbacks, but that interface was later removed and the ContractKeeper interface that we have now only has entry points for the packet callbacks. I will close it now, we can re-open if I am wrong in my reasoning.

@github-project-automation github-project-automation bot moved this from Todo 🏃 to Done 🥳 in ibc-go May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
Archived in project
Development

No branches or pull requests

2 participants