Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a UnmarshalPacketData optional interface function to support ADR 8 callbacks #3349

Closed
3 tasks
colin-axner opened this issue Mar 27, 2023 · 1 comment
Closed
3 tasks
Milestone

Comments

@colin-axner
Copy link
Contributor

Summary

In order for ADR 8 to work generically with the given middleware construction, it needs to ask the underlying app to decode the packet data bytes into an interface function.

Problem Definition

Middleware has no way of generically decoding packet data bytes without making assertions on the underlying app

Proposal

Add an optional interface which IBC apps can implement. It should take in bytes and return an interface. For ICS 20 the FungibleTokenPacketData should be returned. For ICS 27 the InterchainAccountsPacketData should be returned. ADR 8 can cast these interfaces to the CallbacksPacketData if supported.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner
Copy link
Contributor Author

closed by #3353

@crodriguezvega crodriguezvega modified the milestones: v7.1.0, v7.2.0 Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants