Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ICS4Wrapper from keepers and pass it as argument to IBC middleware constructor #3371

Open
crodriguezvega opened this issue Mar 30, 2023 · 2 comments
Assignees
Labels
30-middleware change: api breaking Issues or PRs that break Go API (need to be release in a new major version) type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone

Comments

@crodriguezvega
Copy link
Contributor

Improvement for IBC middleware pipelining as suggested by @damiannolan:

func NewIBCMiddleware(app porttypes.IBCModule, k keeper.Keeper, next porttypes.ICS4Wrapper) IBCMiddleware {
  return IBCMiddleware{
    app:    app,
    keeper: k,
    next:   next,
  }
}
  • Replace in the implementation of the ICS4 wrapper interface in 29-fee and 27-controller the usage of keeper for next.
@crodriguezvega crodriguezvega added type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. change: api breaking Issues or PRs that break Go API (need to be release in a new major version) 30-middleware labels Mar 30, 2023
@crodriguezvega crodriguezvega added this to the v8.0.0 milestone Mar 30, 2023
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Mar 30, 2023
@GNaD13
Copy link
Contributor

GNaD13 commented Apr 12, 2023

Hi @crodriguezvega, Can I take this issue?

@crodriguezvega
Copy link
Contributor Author

Hi @crodriguezvega, Can I take this issue?

Yes, definitely. Thank you, @GNaD13! Let us know if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
30-middleware change: api breaking Issues or PRs that break Go API (need to be release in a new major version) type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
Status: Todo 🏃
3 participants