Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code consistency nits in grpc handler #3422

Closed
3 tasks
colin-axner opened this issue Apr 6, 2023 · 0 comments · Fixed by #3424
Closed
3 tasks

Code consistency nits in grpc handler #3422

colin-axner opened this issue Apr 6, 2023 · 0 comments · Fixed by #3424
Labels
type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@colin-axner
Copy link
Contributor

Summary

  • Use k instead of `q, see comment
  • Unwrap the sdk context first, see comment

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added the type: code hygiene Clean up code but without changing functionality or interfaces label Apr 6, 2023
@ruthishvitwit ruthishvitwit mentioned this issue Apr 7, 2023
Merged
9 tasks
@DimitrisJim DimitrisJim mentioned this issue Apr 11, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix:Changed q's to k and Repositioned UnWrapSDKContext ruthishvitwit/ibc-go
1 participant
@colin-axner