Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider relying solely on local clock time for transfer CLI relative timeouts #3594

Closed
3 tasks
damiannolan opened this issue May 16, 2023 · 2 comments · Fixed by #5908
Closed
3 tasks

Consider relying solely on local clock time for transfer CLI relative timeouts #3594

damiannolan opened this issue May 16, 2023 · 2 comments · Fixed by #5908
Assignees
Milestone

Comments

@damiannolan
Copy link
Contributor

Summary

Relative timeouts currently lookup client state and consensus state in order to retrieve the latest timestamp of the counterparty chain's consensus state when constructing a packet with relative timeouts.

It may be worth relying solely on local clock time to calculate a relative timeout.

Pros:

  • Reduced the amount of the stateful queries on nodes when using a CLI client

Cons:

  • Local clock time must be accurate

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added client-UX 20-transfer needs discussion Issues that need discussion before they can be worked on labels May 16, 2023
@colin-axner colin-axner removed the needs discussion Issues that need discussion before they can be worked on label Feb 26, 2024
@colin-axner colin-axner moved this to Todo 🏃 in ibc-go Feb 26, 2024
@crodriguezvega
Copy link
Contributor

Make transfer and ICA CLIs consistent regarding handling of timeouts.

@damiannolan damiannolan self-assigned this Feb 26, 2024
@damiannolan damiannolan moved this from Todo 🏃 to In progress 👷 in ibc-go Feb 26, 2024
@damiannolan
Copy link
Contributor Author

I'll try to address this issue and rebase the 02-client router work before moving that forward.

@crodriguezvega crodriguezvega added this to the v9.0.0 milestone Feb 27, 2024
@crodriguezvega crodriguezvega moved this from In progress 👷 to In review 👀 in ibc-go Mar 4, 2024
@github-project-automation github-project-automation bot moved this from In review 👀 to Done 🥳 in ibc-go Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants