Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flushing check to WriteUpgradeTryChannel #3928

Closed
3 tasks
colin-axner opened this issue Jun 22, 2023 · 0 comments
Closed
3 tasks

Add flushing check to WriteUpgradeTryChannel #3928

colin-axner opened this issue Jun 22, 2023 · 0 comments
Assignees
Labels
channel-upgradability Channel upgradability feature

Comments

@colin-axner
Copy link
Contributor

Summary

In WriteUpgradeTryChannel account for the channel end already being flushed:

channel.FlushStatus = types.FLUSHING
if  !k.hasInflightPackets(ctx, portID, channelID) {
    channel.FlushStatus = types.FLUSHCOMPLETE
}

It would be nice if we could add some tests, maybe some unit tests for the WriteUpgradeTryChannel func


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
channel-upgradability Channel upgradability feature
Projects
Archived in project
Development

No branches or pull requests

2 participants