Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flushing check to WriteUpgradeAckChannel #3929

Closed
3 tasks
colin-axner opened this issue Jun 22, 2023 · 1 comment
Closed
3 tasks

Add flushing check to WriteUpgradeAckChannel #3929

colin-axner opened this issue Jun 22, 2023 · 1 comment
Assignees
Labels
channel-upgradability Channel upgradability feature

Comments

@colin-axner
Copy link
Contributor

Summary

In WriteUpgradeAckChannel add:

if  !k.hasInflightPackets(ctx, portID, channelID) {
    channel.FlushStatus = types.FLUSHCOMPLETE
}

It would be nice to have some tests as well (maybe some unit tests for the write func)


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added the channel-upgradability Channel upgradability feature label Jun 22, 2023
@colin-axner colin-axner added this to the 04-channel upgrades alpha milestone Jun 22, 2023
@colin-axner colin-axner moved this to Todo in ibc-go Jun 22, 2023
@chatton chatton self-assigned this Jun 27, 2023
@chatton chatton moved this from Todo to In progress in ibc-go Jun 27, 2023
@chatton
Copy link
Contributor

chatton commented Jul 3, 2023

looks like @charleenfei got this one over the line thanks!

@chatton chatton closed this as completed Jul 3, 2023
@github-project-automation github-project-automation bot moved this from In progress to Done in ibc-go Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
channel-upgradability Channel upgradability feature
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants