Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amend the channel closing handlers to set the flushing status to NOTINFLUSH. #3987

Closed
charleenfei opened this issue Jun 30, 2023 · 0 comments
Closed

amend the channel closing handlers to set the flushing status to NOTINFLUSH. #3987

charleenfei opened this issue Jun 30, 2023 · 0 comments
Assignees
@chatton
Labels
channel-upgradability Channel upgradability feature
Milestone
04-channel upgrad...

Comments

@charleenfei
Copy link
Contributor

charleenfei commented Jun 30, 2023 •
edited by crodriguezvega
Loading

I think it currently is possible to be in such a state if a message to close the channel is submitted during the upgrade handshake? Even if I'm missing something and that isn't possible we should definitely amend the channel closing handlers to set the flushing status to NOTINFLUSH.

Originally posted by @DimitrisJim in #3914 (comment)
@crodriguezvega crodriguezvega added the channel-upgradability Channel upgradability feature label Jun 30, 2023
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Jun 30, 2023
@chatton chatton self-assigned this Jul 3, 2023
@chatton chatton mentioned this issue Jul 3, 2023
Merged
9 tasks
@chatton chatton moved this from Todo to In review in ibc-go Jul 3, 2023
@chatton chatton closed this as completed Jul 5, 2023
@github-project-automation github-project-automation bot moved this from In review to Done in ibc-go Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chatton chatton

Labels
channel-upgradability Channel upgradability feature
Projects
ibc-go
Archived in project
Milestone
04-channel upgrades alpha
Development

No branches or pull requests
3 participants
@crodriguezvega @chatton @charleenfei