Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Counterparty lastSequenceSend should be set in startFlushUpgrade #4001

Closed
3 tasks
damiannolan opened this issue Jul 4, 2023 · 0 comments
Closed
3 tasks

Counterparty lastSequenceSend should be set in startFlushUpgrade #4001

damiannolan opened this issue Jul 4, 2023 · 0 comments
Assignees
@chatton
Labels
channel-upgradability Channel upgradability feature
Milestone
04-channel upgrad...

Comments

@damiannolan
Copy link
Member

Summary

It looks like this part of the upgrade flow is missing.
We need to set the counterparty last sequence send in startFlushUpgrade

ref: https://github.com/cosmos/ibc/blob/main/spec/core/ics-004-channel-and-packet-semantics/UPGRADES.md#utility-functions

privateStore.set(channelCounterpartyLastPacketSequencePath(portIdentifier, channelIdentifier), counterpartyUpgrade.lastPacketSent)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added the channel-upgradability Channel upgradability feature label Jul 4, 2023
@damiannolan damiannolan added this to the 04-channel upgrades alpha milestone Jul 4, 2023
@damiannolan damiannolan moved this to Todo in ibc-go Jul 4, 2023
@chatton chatton self-assigned this Jul 4, 2023
@damiannolan damiannolan mentioned this issue Jul 4, 2023
Merged
9 tasks
@damiannolan damiannolan changed the title Countparty lastSequenceSend should be set in startFlushUpgrade Counterparty lastSequenceSend should be set in startFlushUpgrade Jul 4, 2023
@chatton chatton mentioned this issue Jul 4, 2023
Merged
9 tasks
@chatton chatton closed this as completed Jul 5, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in ibc-go Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chatton chatton

Labels
channel-upgradability Channel upgradability feature
Projects
ibc-go
Archived in project
Milestone
04-channel upgrades alpha
Development

No branches or pull requests
2 participants
@damiannolan @chatton