Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GetSignBytes #4102

Closed
3 tasks
colin-axner opened this issue Jul 17, 2023 · 2 comments
Closed
3 tasks

Remove GetSignBytes #4102

colin-axner opened this issue Jul 17, 2023 · 2 comments
Labels
type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@colin-axner
Copy link
Contributor

Summary

In the bump to v0.50, we can remove GetSignBytes, see sdk pr. We should ensure the amino annotations are correct so ledger signing can still be used

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added the type: code hygiene Clean up code but without changing functionality or interfaces label Jul 17, 2023
@crodriguezvega
Copy link
Contributor

We already had this other issue. Can we close this one?

@colin-axner
Copy link
Contributor Author

ah yes, perfect

@github-project-automation github-project-automation bot moved this to Done in ibc-go Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: code hygiene Clean up code but without changing functionality or interfaces
Projects
ibc-go
Status: Done 🥳
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crodriguezvega @colin-axner