-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement transfer
channel upgrades callbacks
#4127
Comments
Opened #4126 for |
The |
Upgrade fields are validated in INIT, TRY and ACK. Now that fields are added to Do you think its fine to no-op on |
Closing this as I think all handlers are more or less completed for channel upgradability in transfer. There is working integration test with fee middleware in #4533. We can open follow ups post-audit if needs be. |
Summary
Implement the channel upgrade callback handlers for
transfer
.Separate PRs can be opened for each callback handler including tests.
The implementation should ensure that the upgrade parameters are compatible with the transfer app.
This includes ordering enforced in
ValidateTransferChannelParams
as well as version checking, i.e. the upgrade version must beics20-1
.OnChanUpgradeInit
OnChanUpgradeTry
OnChanUpgradeAck
OnChanUpgradeOpen
OnChanUpgradeRestore
For Admin Use
The text was updated successfully, but these errors were encountered: