Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ChannelUpgradeConfirm rpc to 04-channel msg service #4244

Closed
3 tasks
Tracked by #4264
, #4265
...
damiannolan opened this issue Aug 2, 2023 · 0 comments
Closed
3 tasks
Tracked by #4264
, #4265
...

Add ChannelUpgradeConfirm rpc to 04-channel msg service #4244

damiannolan opened this issue Aug 2, 2023 · 0 comments
Assignees
@damiannolan
Labels
04-channel channel-upgradability Channel upgradability feature
Milestone
04-channel upgrad...

Comments

@damiannolan
Copy link
Contributor

Summary

  • Add ChannelUpgradeConfirm rpc endpoint to protobuf msg service for 04-channel.
  • Add MsgChannelUpgradeConfirm and response msg with necessary fields defined in the spec

A no-op empty boilerplate method definition should be added to satisfy the compiler.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added 04-channel channel-upgradability Channel upgradability feature labels Aug 2, 2023
@damiannolan damiannolan added this to the 04-channel upgrades alpha milestone Aug 2, 2023
@damiannolan damiannolan moved this to Todo in ibc-go Aug 2, 2023
This was referenced Aug 2, 2023
Closed
Closed
@damiannolan damiannolan self-assigned this Aug 7, 2023
@damiannolan damiannolan moved this from Todo to In progress in ibc-go Aug 7, 2023
@damiannolan damiannolan mentioned this issue Aug 7, 2023
Merged
9 tasks
@damiannolan damiannolan moved this from In progress to In review in ibc-go Aug 7, 2023
@github-project-automation github-project-automation bot moved this from In review to Done in ibc-go Aug 8, 2023
@damiannolan damiannolan mentioned this issue Aug 8, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
04-channel channel-upgradability Channel upgradability feature
Projects
No open projects
ibc-go
Archived in project
Milestone
04-channel upgrades alpha
Development

No branches or pull requests
1 participant
@damiannolan