Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use counterparty upgrade version in upgrade ack if current channel state is OPEN #4248

Closed
3 tasks
damiannolan opened this issue Aug 2, 2023 · 0 comments
Closed
3 tasks
Assignees
Labels
04-channel channel-upgradability Channel upgradability feature

Comments

@damiannolan
Copy link
Contributor

Summary

Add the following logic to ChanUpgradeAck:

If current channel state is OPEN then we accept the counterparty upgrade version as the final upgrade version by assigning it to self upgrade version field.

// optimistically accept version that TRY chain proposes and pass this to callback for confirmation
// in the crossing hello case, we do not modify version that our TRY call returned and instead enforce
// that both TRY calls returned the same version
if currentChannel.state == OPEN {
    upgrade.fields.version == counterpartyUpgrade.fields.version
}

spec ref


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added 04-channel channel-upgradability Channel upgradability feature labels Aug 2, 2023
@damiannolan damiannolan added this to the 04-channel upgrades alpha milestone Aug 2, 2023
@damiannolan damiannolan moved this to Todo in ibc-go Aug 2, 2023
@chatton chatton mentioned this issue Aug 17, 2023
9 tasks
@damiannolan damiannolan moved this from Todo to In review in ibc-go Aug 17, 2023
@chatton chatton closed this as completed Aug 17, 2023
@github-project-automation github-project-automation bot moved this from In review to Done in ibc-go Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
04-channel channel-upgradability Channel upgradability feature
Projects
Archived in project
Development

No branches or pull requests

2 participants