Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for error returned in channel msg_tests #4304

Closed
3 tasks
DimitrisJim opened this issue Aug 7, 2023 · 3 comments · Fixed by #5492
Closed
3 tasks

Check for error returned in channel msg_tests #4304

DimitrisJim opened this issue Aug 7, 2023 · 3 comments · Fixed by #5492
Assignees
@expertdicer
Labels
nice-to-have testing Testing package and unit/integration tests

Comments

@DimitrisJim
Copy link
Contributor

Summary

We should check for the error returned in tests that check each message's ValidateBasic.

☔ issue #3778

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim DimitrisJim added testing Testing package and unit/integration tests nice-to-have labels Aug 7, 2023
@DimitrisJim
Copy link
Contributor Author

should probably be done after 04-channel-upgrades is merged.

@expertdicer
Copy link
Contributor

Can i take the issue ? TYSM

@DimitrisJim
Copy link
Contributor Author

I do not see why you couldn't!

@expertdicer expertdicer mentioned this issue Dec 23, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@expertdicer expertdicer

Labels
nice-to-have testing Testing package and unit/integration tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check for error returned in channel msg_tests Genuine-labs/ibc-go
2 participants
@DimitrisJim @expertdicer