Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getUpgradeTimeout function to calculate timeout for packet flushing in upgrades #4313

Closed
3 tasks
damiannolan opened this issue Aug 8, 2023 · 1 comment
Closed
3 tasks
Assignees
Labels
04-channel channel-upgradability Channel upgradability feature needs discussion Issues that need discussion before they can be worked on

Comments

@damiannolan
Copy link
Member

Summary

Determine how upgrade timeouts for packet processing will be calculated. E.g. via on-chain parameter?

As stated by the spec:

getUpgradeTimeout will return the upgrade timeout specified for the given channel. This may be a chain-wide parameter, or it can be a parameter chosen per channel. This is an implementation-level detail, so only the function signature is specified here. Note this should retrieve some stored timeout delta for the channel and add it to the current height and time to get the absolute timeout values.

function getUpgradeTimeout(portIdentifier: string, channelIdentifier: string) UpgradeTimeout {
}

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added needs discussion Issues that need discussion before they can be worked on 04-channel channel-upgradability Channel upgradability feature labels Aug 8, 2023
@damiannolan damiannolan added this to the 04-channel upgrades alpha milestone Aug 8, 2023
@damiannolan damiannolan moved this to Todo in ibc-go Aug 8, 2023
@chatton chatton self-assigned this Aug 21, 2023
@damiannolan
Copy link
Member Author

See #4441 for more context, should be linked to this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
04-channel channel-upgradability Channel upgradability feature needs discussion Issues that need discussion before they can be worked on
Projects
Status: Done 🥳
Development

No branches or pull requests

2 participants