Refactor TestWriteUpgradeCancelChannel to use table tests

[damiannolan]

Refactor TestWriteUpgradeCancelChannel to use table-driven tests.

Originally posted by @damiannolan in #4404 (comment)

[faddat]

@damiannolan please assign @ThanhNhann to this task. He's amazing with tests.

[damiannolan]

That'd be awesome, thanks! I was thinking we could use this kind of test structure:

testCases := []struct{
    name string
    malleate func()
    expError error
}{
        {
             "success",
             func() {},
             nil,
        },
        // failure scenarios with expected error
}

We can take the existing test setup and move it to the test body and make some assertions based on the inputs of WriteUpgradeCancelChannel mutated by malleate().

I'll assign @ThanhNhann, feel free to make a PR and reach out if you've any questions

edit: cc @crodriguezvega for issue assignment, for some reason my GH assignees filter isn't finding @ThanhNhann

edit: @ThanhNhann you'll probably want to target the #4404 branch as upstream for now 👍

[DimitrisJim]

I think @ThanhNhann might need to drop a comment here, assigning has some restrictions apparently https://docs.github.com/en/issues/tracking-your-work-with-issues/assigning-issues-and-pull-requests-to-other-github-users#about-issue-and-pull-request-assignees

[crodriguezvega]

I think @ThanhNhann might need to drop a comment here, assigning has some restrictions apparently https://docs.github.com/en/issues/tracking-your-work-with-issues/assigning-issues-and-pull-requests-to-other-github-users#about-issue-and-pull-request-assignees

Yes, correct. @ThanhNhann needs to comment here first. :)

[ThanhNhann]

Hi all, I'm here now, plz assign me for this task 😄