Remove GetSigners from sdk.Msg implementations

[damiannolan]

Summary

The GetSigners method has been deprecated in favour of proto annotations. It can be removed.

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged/assigned

[CyberGA]

Hi @damiannolan
I would like to work on this. Is it just to remove the GetSigners?
Am I replacing it with anything?

[damiannolan]

Hey @CyberGA, feel free to work on this issue! I can assign you. Thanks a lot!

Yes we can just remove the GetSigners method for each implementation of the sdk.Msg. The msgs are maintained under the types package of each module (transfer, interchain-accounts, 29-fee, ibc core). You can find them in the msgs.go file.

There no need to do any to replace them. The functionality has already been replaced using protobuf annotations. See here for example

[CyberGA]

Okay I will work on it

[DimitrisJim]

ayo @CyberGA still have time to work on this? If not, we can assign it elsewhere. An example of how this should look can be seen in linked PR.

[CyberGA]

ayo @CyberGA still have time to work on this? If not, we can assign it elsewhere. An example of how this should look can be seen in linked PR.

Please assign it to someone else. Thanks

[damiannolan]

I can do it 👍

[ThanhNhann]

Hey @damiannolan, do you still work on this? if you don't have time, I think I can handle it 😄

[damiannolan]

@ThanhNhann be my guest! I'll assign you :)

[DimitrisJim]

small note: we shouldn't close this issue after #5305, these should also be removed for new messages added for channel upgradability.

[hoangdv2429]

@damiannolan @DimitrisJim sirs can I continue the work on this ?

[DimitrisJim]

Depends on if @ThanhNhann is still working on it, if not, I don't see why not!

[ThanhNhann]

thank @hoangdv2429 but I'm working on it, you can check other issues and solve them too 🤝

[DimitrisJim]

completed in #5352, thank you for taking this on @ThanhNhann 💪