Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establish an interface the Endpoint type in the testing pkg can use to interact with TestChains generically #4808

Open
3 tasks
colin-axner opened this issue Oct 4, 2023 · 0 comments
Labels
needs discussion Issues that need discussion before they can be worked on testing Testing package and unit/integration tests type: dependency management Relating to managing the ibc dependency graph

Comments

@colin-axner
Copy link
Contributor

Summary

In a similar sentiment to #4807, an interface should be established for allowing the endpoint to work with any type of TestChain, not just the one implemented in ibc-go. This is primarily beneficial for simplifying solo machine tests and enabling usage of the testing pkg by other light client modules written in go.

Problem Definition

The Endpoint type currently references a concrete type rather than an interface. The current concrete type is a mock cometbft chain, by determining the interface the Endpoint type uses from the TestChain, we can enable the Endpoint to be used generically with a variety of TestChain's and light client modules.

Proposal

Turn the chain reference in the Endpoint into an interface. This will require having a interface function for proof queries and submitting msgs at a minimum. It should be developed with the solo machine in mind as that is likely to give a good influence on the required interfaces and how to structure them in a way that makes it easy for light client modules to plug into the testing pkg


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added needs discussion Issues that need discussion before they can be worked on testing Testing package and unit/integration tests labels Oct 4, 2023
@colin-axner colin-axner removed the needs discussion Issues that need discussion before they can be worked on label Jan 15, 2024
@colin-axner colin-axner added the type: dependency management Relating to managing the ibc dependency graph label May 15, 2024
@colin-axner colin-axner added the needs discussion Issues that need discussion before they can be worked on label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs discussion Issues that need discussion before they can be worked on testing Testing package and unit/integration tests type: dependency management Relating to managing the ibc dependency graph
Projects
Status: Backlog 🕐
Development

No branches or pull requests

1 participant