Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split channel keeper expected interface into channel keeper and ics4 wrapper #514

Closed
3 tasks
colin-axner opened this issue Nov 1, 2021 · 1 comment
Closed
3 tasks
Assignees
Labels

Comments

@colin-axner
Copy link
Contributor

Summary

Currently ics29 fee uses the channelKeeper interface as both the channel keeper and ics4 wrapper. The issue is other applications may require more functions from the channel keeper than just send packet and write acknowledgement. For example, interchain accounts requires ChanOpenInit.

This concern was accounted for in the middleware documentation. We should apply this design to ics29 and ics27 by having two interfaces: channelKeeper and ics4Wrapper. The keeper for the ibc application should receive the app above it as the ics4wrapper and the ibc core channel keeper as the channel keeper


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner
Copy link
Contributor Author

This has been addressed in interchain accounts with #417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

3 participants