Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MetadataFromVersion when unmarshalling JSON-encoded metadata #5298

Closed
1 task
crodriguezvega opened this issue Dec 2, 2023 · 3 comments
Closed
1 task

Use MetadataFromVersion when unmarshalling JSON-encoded metadata #5298

crodriguezvega opened this issue Dec 2, 2023 · 3 comments
Assignees
@vishal-kanna
Labels
27-interchain-accounts good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@crodriguezvega
Copy link
Contributor

crodriguezvega commented Dec 2, 2023 •
edited
Loading

Pre-requisite:

There are a few places of the 27-interchain-accounts module (like this, this and this) where we can use the function MetadataFromVersion that is being introduced in #5141.

If this issue is taken before the 04-channel-upgrades feature branch is merged to main, then please open the PR against 04-channel-upgrades branch.
@crodriguezvega crodriguezvega added 27-interchain-accounts type: code hygiene Clean up code but without changing functionality or interfaces good first issue Good for newcomers labels Dec 2, 2023
@crodriguezvega crodriguezvega changed the title I will open an issue to use this function in a few places of the the 27-interchain-accounts module (like [this](https://github.com/cosmos/ibc-go/blob/2bd29c08fd1fe50b461fc33a25735aa792dc896e/modules/apps/27-interchain-accounts/controller/keeper/handshake.go#L54-L56), [this](https://github.com/cosmos/ibc-go/blob/2bd29c08fd1fe50b461fc33a25735aa792dc896e/modules/apps/27-interchain-accounts/controller/keeper/handshake.go#L104-L106) and [this](https://github.com/cosmos/ibc-go/blob/2bd29c08fd1fe50b461fc33a25735aa792dc896e/modules/apps/27-interchain-accounts/host/keeper/handshake.go#L39-L41)) when we merge the feature branch Use MetadataFromVersion when unmarshalling JSON-encoded metadata Dec 2, 2023
@vishal-kanna
Copy link
Contributor

@crodriguezvega Can i take this issue?

@crodriguezvega
Copy link
Contributor Author

@crodriguezvega Can i take this issue?

Yes, @vishal-kanna, thank you! We need this PR merged first. Or alternatively you could copy the function from that PR and start working already on it. Hopefully when your PR is opened there are not merge conflicts.

@crodriguezvega crodriguezvega mentioned this issue Dec 4, 2023
Merged
9 tasks
@crodriguezvega
Copy link
Contributor Author

Closed by #5300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vishal-kanna vishal-kanna

Labels
27-interchain-accounts good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crodriguezvega @vishal-kanna