Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require authority to pass proof if self channel state is in FLUSHCOMPLETE for upgrade cancellation #5319

Closed
colin-axner opened this issue Dec 5, 2023 · 0 comments
Assignees
Labels
channel-upgradability Channel upgradability feature

Comments

@colin-axner
Copy link
Contributor

As per code comment:

// if the msgSender is authorized to make and cancel upgrades AND the current channel has not already reached FLUSHCOMPLETE
// then we can restore immediately without any additional checks
// otherwise, we can only cancel if the counterparty wrote an error receipt during the upgrade handshake

If the channel state is in FLUSHCOMPLETE, regardless of whether the authority called this function, we must prove that the counterparty wrote an error receipt for a valid upgrade sequence. Otherwise the authority could cancel an upgrade while the counterparty simultaneously is provided historical proof to upgrade to open. In this case, the authority would be harming itself, but no harm in ensuring this isn't possible

Originally posted by @colin-axner in #5262 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
channel-upgradability Channel upgradability feature
Projects
Archived in project
Development

No branches or pull requests

3 participants