Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove VerifyChannelUpgradeErrorAbsence from 03-connection #5477

Closed
damiannolan opened this issue Dec 21, 2023 · 2 comments · Fixed by #5532
Closed

Remove VerifyChannelUpgradeErrorAbsence from 03-connection #5477

damiannolan opened this issue Dec 21, 2023 · 2 comments · Fixed by #5532
Assignees
@vishal-kanna
Labels
channel-upgradability Channel upgradability feature good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@damiannolan
Copy link
Contributor

Remove VerifyChannelUpgradeErrorAbsence from 03-connection.

It's no longer required

Originally posted by @damiannolan in #1613 (comment)
@damiannolan damiannolan changed the title I don't think this is used anymore? Remove VerifyChannelUpgradeErrorAbsence from 03-connection Dec 21, 2023
@damiannolan damiannolan added type: code hygiene Clean up code but without changing functionality or interfaces channel-upgradability Channel upgradability feature labels Dec 21, 2023
@damiannolan damiannolan added this to the 04-channel upgrades RC milestone Dec 21, 2023
@damiannolan damiannolan mentioned this issue Dec 21, 2023
Merged
9 tasks
@crodriguezvega crodriguezvega added the good first issue Good for newcomers label Dec 21, 2023
@vishal-kanna
Copy link
Contributor

@damiannolan I would like to work on it

@crodriguezvega
Copy link
Contributor

crodriguezvega commented Jan 1, 2024 •
edited
Loading

@damiannolan I would like to work on it

@vishal-kanna Sorry for the later reply, we've all been on holiday during the Christmas break. :)

Yes, I will assign it to you now. Thank you!

@crodriguezvega crodriguezvega moved this to Todo in ibc-go Jan 1, 2024
@crodriguezvega crodriguezvega removed this from the 04-channel upgrades RC milestone Jan 5, 2024
@vishal-kanna vishal-kanna mentioned this issue Jan 6, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in ibc-go Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vishal-kanna vishal-kanna

Labels
channel-upgradability Channel upgradability feature good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces
Projects
ibc-go
Status: Done 🥳
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: removed verifychannelupgradeErrorAbsence from the 03-connection vishal-kanna/ibc-go
3 participants
@damiannolan @crodriguezvega @vishal-kanna