Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ICS4Wrapper interface to use channeltypes.Packet in WriteAcknowledgement interface func #5774

Open
3 tasks
colin-axner opened this issue Jan 30, 2024 · 4 comments
Labels
icebox Issues that we will not address for the time being
Milestone

Comments

@colin-axner
Copy link
Contributor

Summary

We should make this change in conjunction with the next required breaking changes to the WriteAcknowledgement function in the ICS4Wrapper. I suspect this might be when we move the interface to its own api go.mod. We cannot make this change until then to avoid disruption


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added the icebox Issues that we will not address for the time being label Jan 30, 2024
@colin-axner
Copy link
Contributor Author

We can remove exported.PacketI when we remove this usage as well

@hoangdv2429
Copy link
Contributor

Can I work on this one sir @colin-axner

@colin-axner
Copy link
Contributor Author

Hi @hoangdv2429, thanks for your interest, but for now we will need to let this issue sit some time longer. We don't want to break the existing interface unless we have to, so we will let this one be for now

@colin-axner
Copy link
Contributor Author

Also going to note the work in #5819 might remove the ICS4Wrapper entirely or replace it with some new interface

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icebox Issues that we will not address for the time being
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants