Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go to 1.22 #5776

Closed
2 of 3 tasks
DimitrisJim opened this issue Jan 31, 2024 · 1 comment · Fixed by #6380
Closed
2 of 3 tasks

Bump go to 1.22 #5776

DimitrisJim opened this issue Jan 31, 2024 · 1 comment · Fixed by #6380
Assignees
Labels
dependencies Issues or PRs to update a dependency type: code hygiene Clean up code but without changing functionality or interfaces
Milestone

Comments

@DimitrisJim
Copy link
Contributor

DimitrisJim commented Jan 31, 2024

New version of go appears to be slated for a February release. Opening issue to keep track of places where this bump should be made:

  • Each go.mod for all modules.
  • Workflow files that use 'setup-go'.
  • The go.work.example file.
  • Dockerfiles for ibc-go, callbacks, 08-wasm (along with supported alpine version)
  • Version matrix in RELEASES.md.

Feel free to edit this list if I missed something.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim DimitrisJim added the type: code hygiene Clean up code but without changing functionality or interfaces label Jan 31, 2024
@crodriguezvega crodriguezvega added the dependencies Issues or PRs to update a dependency label Jan 31, 2024
@DimitrisJim DimitrisJim moved this to Backlog in ibc-go Jan 31, 2024
@DimitrisJim
Copy link
Contributor Author

Released. Go 1.22 enables scoping per iteration for loop variables https://go.googlesource.com/proposal/+/master/design/60078-loopvar.md which could slightly change loop semantics in certain cases.

Unit tests run fine locally but checking for places in our (and our dependencies) that this change affects using -gcflags=all=-d=loopvar=2) passed during build, there's plenty.

Think there's no need to rush here, we can wait for a bit before bumping.

@crodriguezvega crodriguezvega added this to the v9.0.0 milestone Mar 12, 2024
@crodriguezvega crodriguezvega moved this from Backlog 🕐 to Todo 🏃 in ibc-go Mar 12, 2024
@crodriguezvega crodriguezvega mentioned this issue May 24, 2024
10 tasks
@crodriguezvega crodriguezvega moved this from Todo 🏃 to In review 👀 in ibc-go May 24, 2024
@crodriguezvega crodriguezvega self-assigned this May 24, 2024
@github-project-automation github-project-automation bot moved this from In review 👀 to Done 🥳 in ibc-go May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Issues or PRs to update a dependency type: code hygiene Clean up code but without changing functionality or interfaces
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants