You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I suggested moving the proto definition to proto pkg v3 to see what it would look like seeing as it kind of makes sense to follow some proto rules. But maybe adding FunginbleTokenPacketDataV2 or some other option is less noisy given that we are already on proto pkg v2.
When proto pkg v2 was added for packet data with amount as string we removed the v1 proto definition (ref), but this scenario is different given we want to maintain the existing packet data in parallel. There is a few different options here as @srdtrk has pointed out. I think we should avoid ics20-3 at all costs - this would add too much confusion 😅
I think another option is probably making the new packet data the proto pkg v2 FungibleTokenPacketData and renaming the existing one to have the V1 suffix or "Legacy" prefix or something. That might be a cleaner option completely, rather than introducing proto pkg v3 - I think this should be possible but will need to look into it a bit more, any thoughts on this?
Originally posted by @damiannolan in #6116 (comment)_
The text was updated successfully, but these errors were encountered: