Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide on validation for merkle path prefix in MsgProvideCounterParty #6989

Closed
3 tasks
DimitrisJim opened this issue Jul 30, 2024 · 3 comments · Fixed by #7193
Closed
3 tasks

Decide on validation for merkle path prefix in MsgProvideCounterParty #6989

DimitrisJim opened this issue Jul 30, 2024 · 3 comments · Fixed by #7193
Assignees
@AdityaSripal
Labels
needs discussion Issues that need discussion before they can be worked on type: feature New features, sub-features or integrations
Milestone
Eureka alpha

Comments

@DimitrisJim
Copy link
Contributor

Raised by Aditya in #6982 (comment)

We should probably validate the merkle path prefix as well. Unclear what exactly we should check yet. Let's make an issue for it so we don't lose track of it.

Will be handled by ibc-go team.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim DimitrisJim added this to the Eureka alpha milestone Jul 30, 2024
@DimitrisJim DimitrisJim mentioned this issue Jul 30, 2024
Merged
10 tasks
@DimitrisJim DimitrisJim added the needs discussion Issues that need discussion before they can be worked on label Aug 1, 2024
@DimitrisJim
Copy link
Contributor Author

Note that current validation in Counterparty simply asserts that MerklePath is not empty, this is what the validation for connections did previously.

Slapping needs-discussion label on this and if we decide the current check suffices, we can close the issue.

@crodriguezvega crodriguezvega added the type: feature New features, sub-features or integrations label Aug 8, 2024
@colin-axner colin-axner self-assigned this Aug 12, 2024
@colin-axner
Copy link
Contributor

Well, correct me if I am wrong, but all path elements must be non-empty except the last?

In addition, we could do length restriction on each path element, but it would be arbitrary

@colin-axner colin-axner moved this to On hold ❌ in IBC Eureka Aug 13, 2024
@AdityaSripal AdityaSripal mentioned this issue Aug 20, 2024
Merged
10 tasks
@crodriguezvega crodriguezvega moved this from On hold ❌ to In review 👀 in IBC Eureka Aug 26, 2024
@crodriguezvega
Copy link
Contributor

Closed by #7193

@github-project-automation github-project-automation bot moved this from In review 👀 to Done 🥳 in IBC Eureka Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdityaSripal AdityaSripal

Labels
needs discussion Issues that need discussion before they can be worked on type: feature New features, sub-features or integrations
Projects
No open projects
IBC Eureka
Archived in project
Milestone
Eureka alpha
Development

Successfully merging a pull request may close this issue.

Validate MerklePathPrefix and Path cosmos/ibc-go
4 participants
@crodriguezvega @DimitrisJim @AdityaSripal @colin-axner