Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check SendPacket codecov #7153

Closed
3 tasks
colin-axner opened this issue Aug 13, 2024 · 2 comments
Closed
3 tasks

Check SendPacket codecov #7153

colin-axner opened this issue Aug 13, 2024 · 2 comments
Assignees
@DimitrisJim
Labels
feat: ibc-eureka testing Testing package and unit/integration tests
Milestone
Eureka alpha

Comments

@colin-axner
Copy link
Contributor

Summary

See comment. Can close issue if decided to be not possible

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added testing Testing package and unit/integration tests feat: ibc-eureka labels Aug 13, 2024
@colin-axner colin-axner added this to the Eureka alpha milestone Aug 13, 2024
@crodriguezvega crodriguezvega removed this from ibc-go Aug 15, 2024
@crodriguezvega crodriguezvega moved this to Todo 🏃 in IBC Eureka Aug 15, 2024
@DimitrisJim DimitrisJim self-assigned this Aug 27, 2024
@DimitrisJim
Copy link
Contributor

Checked cov, missing it for the latest height check and latest timestamp check. Was not able to trigger one for latest timestamp, was getting rugged by status check failing if I tried to alter things to get it working, this is also not covered in 04-channel's version of SendPacket.

Added the cov for latest height. Feel free to drop review in PR with ideas for covering latest timestamp.

@DimitrisJim DimitrisJim mentioned this issue Aug 27, 2024
Merged
10 tasks
@DimitrisJim DimitrisJim moved this from Todo 🏃 to In review 👀 in IBC Eureka Aug 27, 2024
@DimitrisJim
Copy link
Contributor

done in #7212

@github-project-automation github-project-automation bot moved this from In review 👀 to Done 🥳 in IBC Eureka Aug 27, 2024
@tankcdr tankcdr added this to IBC Sep 27, 2024
@tankcdr tankcdr moved this to Backlog in IBC Sep 27, 2024
@damiannolan damiannolan moved this from Backlog to Done in IBC Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DimitrisJim DimitrisJim

Labels
feat: ibc-eureka testing Testing package and unit/integration tests
Projects
IBC
Status: Done
IBC Eureka
Archived in project
Milestone
Eureka alpha
Development

No branches or pull requests
2 participants
@DimitrisJim @colin-axner