Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change TestCommitPacket to use table tests #7503

Closed
4 tasks
DimitrisJim opened this issue Oct 22, 2024 · 2 comments · Fixed by #7514
Closed
4 tasks

Change TestCommitPacket to use table tests #7503

DimitrisJim opened this issue Oct 22, 2024 · 2 comments · Fixed by #7514
Assignees
@cl1ckname
Labels
good first issue Good for newcomers testing Testing package and unit/integration tests

Comments

@DimitrisJim
Copy link
Contributor

See comment here #7498 (comment)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
  • Estimate provided
@DimitrisJim DimitrisJim added testing Testing package and unit/integration tests good first issue Good for newcomers labels Oct 22, 2024
@DimitrisJim DimitrisJim mentioned this issue Oct 22, 2024
Merged
10 tasks
@cl1ckname
Copy link
Contributor

Hi, I would like to do this. I have already read the contributing guideline and feel empowered to write it. Can I get an assign?

@damiannolan
Copy link
Contributor

Hey @cl1ckname, thanks for volunteering to pick this up! When you PR against the repo, please check the box that says "Allow edits from maintainers", that can help us keep the branch in sync and help you out with any follow up commits on your branch!

@cl1ckname cl1ckname mentioned this issue Oct 23, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cl1ckname cl1ckname

Labels
good first issue Good for newcomers testing Testing package and unit/integration tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: ensure that the packet commit changes if the packed fields changes cl1ckname/ibc-go
3 participants
@damiannolan @DimitrisJim @cl1ckname