Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do chain-id length validation #96

Closed
3 tasks
colin-axner opened this issue Mar 29, 2021 · 0 comments · Fixed by #99
Closed
3 tasks

Do chain-id length validation #96

colin-axner opened this issue Mar 29, 2021 · 0 comments · Fixed by #99
Milestone
1.0.0

Comments

@colin-axner
Copy link
Contributor

Summary

Tendermint enforces a max chain-id length. This is checked in the signed header validate basic, but it is not checked in IBC client creation. We should add a check for this usin gthe types.MaxChainIDLen parameters.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner mentioned this issue Mar 30, 2021
Merged
9 tasks
@colin-axner colin-axner added this to the 1.1.0 milestone Mar 30, 2021
faddat referenced this issue in notional-labs/ibc-go Mar 1, 2022
@jackzampolin
Merge PR #96: iqlusioninc
d68bc76 
Add iqlusionchain to testnet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Add max length chain-id check on tendermint client cosmos/ibc-go
1 participant
@colin-axner