Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

29-fee/types tests should use standard testing pkg: types_test #980

Closed
3 tasks
damiannolan opened this issue Feb 23, 2022 · 0 comments
Closed
3 tasks

29-fee/types tests should use standard testing pkg: types_test #980

damiannolan opened this issue Feb 23, 2022 · 0 comments
Assignees
Labels
29-fee testing Testing package and unit/integration tests

Comments

@damiannolan
Copy link
Contributor

Summary

Tests maintained in 29-fee/types should be updated to follow the same testing package standard used throughout the ibc-go repository.

When writing tests I stumbled upon an import cycle when using ibctesting.MockFeePort, this can avoided by using:

package types_test

in favour of:

package types

All tests under pkg types will need to be updated to accommodate this


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added testing Testing package and unit/integration tests 29-fee labels Feb 23, 2022
@damiannolan damiannolan self-assigned this Feb 23, 2022
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Feb 23, 2022
@crodriguezvega crodriguezvega moved this from Todo to In progress in ibc-go Feb 23, 2022
Repository owner moved this from In progress to Done in ibc-go Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
29-fee testing Testing package and unit/integration tests
Projects
Archived in project
Development

No branches or pull requests

1 participant