Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and clean the validate_basic method #135

Closed
Shivani912 opened this issue Jun 10, 2020 · 0 comments
Closed

Investigate and clean the validate_basic method #135

Shivani912 opened this issue Jun 10, 2020 · 0 comments
Assignees

Comments

@Shivani912
Copy link

Shivani912 commented Jun 10, 2020

The method validate_basic appears in almost all domain type definitions, e.g., Counterparty, ConnectionEnd, MsgConnectionOpenConfirm, etc. In most of the implementations, this method returns an Ok() result. It's unclear if we should keep it around.

Investigate:

  • What was the original intended purpose of validate_basic?
  • Can we remove it altogether, or do some types still need it? Intuitively, conversion from the Raw type into the domain type (see below an example) handles all validation. Domain types are a rather new features, and perhaps they make the method validate_basic unnecessary.

https://github.com/informalsystems/ibc-rs/blob/2b5029b50e1cfd4181e2dfcf8d1b76c7b9d833e6/modules/src/ics03_connection/msgs/conn_open_init.rs#L84-L99

@adizere adizere changed the title Todo: validate Counterparty Investigate and clean the validate_basic method Nov 5, 2020
@adizere adizere assigned adizere and ancazamfir and unassigned adizere Jan 14, 2021
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants