Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClientState in MsgConnectionOpenTry must not be optional #159

Closed
5 tasks
plafer opened this issue Oct 7, 2022 · 1 comment · Fixed by #160
Closed
5 tasks

ClientState in MsgConnectionOpenTry must not be optional #159

plafer opened this issue Oct 7, 2022 · 1 comment · Fixed by #160

Comments

@plafer
Copy link
Contributor

plafer commented Oct 7, 2022 •
edited
Loading

Summary of Bug

We currently allow the relayer not to send a ClientState in MsgConnectionOpenTry and MsgConnectionOpenAck, and the handler can potentially succeed. This is incorrect. See ibc-go and the standard for OpenTry (analogous for OpenAck).

Related: #15

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
This was referenced Oct 7, 2022
Closed
Merged
@plafer
Copy link
Contributor Author

plafer commented Oct 11, 2022

Duplicate of #16

@plafer plafer marked this as a duplicate of #16 Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make ClientState not optional in MsgConnectionOpen{Try,Ack} informalsystems/ibc-rs
1 participant
@plafer