You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reviewing the codes, came across lints that trigger cargo clippy while working with different Rust toolchains.
Also, some clippy exceptions could be swept to achieve a consistent practice as mentioned here
To Do
Use variables directly in the format! & write! strings
Change the type trusted_validator_set field of MisbehaviourTrustedValidatorHashMismatch to avoid large_enum_variant
Box MockHeader and SyntheticTmBlock types of mock/host.rs
Remove unnecessary clippy::large_enum_variant, clippy::ptr_arg, and clippy::wrong_self_convention
Drop #[allow(clippy::too_many_arguments)] Note: This requires a rework of the functions with an excessive number of arguments. It can be handled in a separate issue.
Summary of Bug
Reviewing the codes, came across lints that trigger
cargo clippy
while working with different Rust toolchains.Also, some clippy exceptions could be swept to achieve a consistent practice as mentioned here
To Do
format!
&write!
stringstrusted_validator_set
field ofMisbehaviourTrustedValidatorHashMismatch
to avoidlarge_enum_variant
MockHeader
andSyntheticTmBlock
types ofmock/host.rs
clippy::large_enum_variant
,clippy::ptr_arg
, andclippy::wrong_self_convention
#[allow(clippy::too_many_arguments)]
Note: This requires a rework of the functions with an excessive number of arguments. It can be handled in a separate issue.
Version
rustc 1.66.0 (69f9c33d7 2022-12-12)
clippy 0.1.66
clippy 0.1.67
Toolchains:
Steps to Reproduce
For Admin Use
The text was updated successfully, but these errors were encountered: