Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out common format for IBC events #31

Closed
milosevic opened this issue Jun 12, 2020 · 4 comments
Closed

Figure out common format for IBC events #31

milosevic opened this issue Jun 12, 2020 · 4 comments

Comments

@milosevic
Copy link

Tendermint currently outputs IBC events as bulk of strings. This leads to lot of manual and potentially error prone code on the relayer side.

Ideally IBC events are defined using Protobuf and Tendermint should emits it using this format. This eliminates lot of boilerplate and error prone code on the relayer side.

@ebuchman
Copy link
Member

What does it take to achieve these? Are we coordinating with the SDK team on what this would look like? Is there an open issue there for this that we can link?

In the meantime I think we can bump the milestone

@adizere
Copy link
Contributor

adizere commented Oct 6, 2020

I think this is some relevant work from the SDK team cosmos/cosmos-sdk#7406, which is being reworked at the moment. We should align with them once the refactored ADR 031 kicks in.

@adizere
Copy link
Contributor

adizere commented Feb 8, 2021

Linking a new issues from the spec repo related to this https://github.com/cosmos/ics/issues/512

@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 28, 2022
livelybug referenced this issue in octopus-network/ibc-rs Oct 14, 2022
Closes: #30

Query of client consensus now distinguishes between query height
and consensus height.

Specifically:

- `chain_height` is the height at which the query is made
  (can be 0 if the latest state on chain is queried).

- `consensus_height` is the consensus height of the client running on this chain
  but it represents a height of the client's chain and should be used to
  construct the query path.
@plafer
Copy link
Contributor

plafer commented Dec 13, 2022

There is now an issue on the spec repo; we should continue the discussion there.

@plafer plafer closed this as completed Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants