-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure out common format for IBC events #31
Comments
What does it take to achieve these? Are we coordinating with the SDK team on what this would look like? Is there an open issue there for this that we can link? In the meantime I think we can bump the milestone |
I think this is some relevant work from the SDK team cosmos/cosmos-sdk#7406, which is being reworked at the moment. We should align with them once the refactored ADR 031 kicks in. |
Linking a new issues from the spec repo related to this https://github.com/cosmos/ics/issues/512 |
Closes: #30 Query of client consensus now distinguishes between query height and consensus height. Specifically: - `chain_height` is the height at which the query is made (can be 0 if the latest state on chain is queried). - `consensus_height` is the consensus height of the client running on this chain but it represents a height of the client's chain and should be used to construct the query path.
There is now an issue on the spec repo; we should continue the discussion there. |
Tendermint currently outputs IBC events as bulk of strings. This leads to lot of manual and potentially error prone code on the relayer side.
Ideally IBC events are defined using Protobuf and Tendermint should emits it using this format. This eliminates lot of boilerplate and error prone code on the relayer side.
The text was updated successfully, but these errors were encountered: