About the use of WriteAcknowledgement

[DaviRain-Su]

I found the handling of writeAcknowledgement in the read spec, and it seems that there is no handling of writeAknowledgement in ibc-rs

Summary of Bug

• This is ics04channel packet_callback, This no deal with WriteAcknowledgement :

  ibc-rs/modules/src/core/ics04_channel/handler.rs

  Line 206 in a189902

  PacketMsg::RecvPacket(msg) => {

• In Applications/transfer, also no deal with this:

  ibc-rs/modules/src/applications/transfer/context.rs

  Line 204 in a189902

  pub fn on_recv_packet<Ctx: 'static + Ics20Context>(

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate milestone (priority) applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[hu55a1n1]

Nice catch @DaviRain-Su! ibc-rs indeed does not handle the synchronous case for writeAcknowledgement. 👍
I think the best place to implement this would be in the crate::core::ics04_channel::handler::packet_callback after these lines (similar to how ibc-go does it) ->

ibc-rs/modules/src/core/ics04_channel/handler.rs

Lines 209 to 213 in a189902

	OnRecvPacketAck::Nil(write_fn) | OnRecvPacketAck::Successful(_, write_fn) => {
	write_fn(cb.as_any_mut()).map_err(Error::app_module)?;
	}
	OnRecvPacketAck::Failed(_) => {}
	}

Here's a related issue -> https://github.com/informalsystems/ibc-rs/issues/1525
Would you like to take a stab at fixing this? Happy to help review and merge it. Otherwise will fix this before the next release.

[hu55a1n1]

Related issue/bug -> #35.

[DaviRain-Su]

Here's a related issue -> https://github.com/informalsystems/ibc-rs/issues/1525
Would you like to take a stab at fixing this? Happy to help review and merge it. Otherwise will fix this before the next release.

Based on your feedback I made an attempt to modify