Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ics20Reader::get_channel_escrow_address() default impl is inconsistent with Ics20Reader::AccountId #37

Closed
5 tasks
hu55a1n1 opened this issue Jul 11, 2022 · 0 comments · Fixed by informalsystems/hermes#2390
Assignees
Labels
A: bug Admin: something isn't working

Comments

@hu55a1n1
Copy link
Contributor

Summary of Bug

The provided implementation of the Ics20Reader::get_channel_escrow_address() trait method assumes that the Ics20Reader::AccountId type is not encoded (which is unlikely in practise).

The problem is that most host implementations (including the Cosmos SDK) would use a bech32 encoded AccountId whereas the AccountId returned by get_channel_escrow_address() (and the underlying cosmos_adr028_escrow_address() function that it uses) isn't bech32 encoded.

Version

v0.16.0

Acceptance Criteria

Ics20Reader::get_channel_escrow_address() returns a bech32 encoded address or cosmos_adr028_escrow_address() is made public.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@hu55a1n1 hu55a1n1 added the A: bug Admin: something isn't working label Jul 11, 2022
@hu55a1n1 hu55a1n1 self-assigned this Jul 11, 2022
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant