Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify the header's expected value of ibc_to_abci_client_events test with an event from ibc-go #374

Open
Farhad-Shabani opened this issue Jan 24, 2023 · 0 comments
Labels
A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews O: testing Objective: aims to improve testing coverage

Comments

@Farhad-Shabani
Copy link
Member

Summary

Verify the header's expected string value in ibc_to_abci_client_events() test with an emitted event on the ibc-go

Details

The testing chain (respectively generated header) structure & params on ibc-go does not correspond with the dummy header we create through get_dummy_ics07_header() function. we already run the test with the mock header. Thus, it tests the conversion internally, but does not check it against an emitted UpdateClient event on ibc-go

@Farhad-Shabani Farhad-Shabani added O: testing Objective: aims to improve testing coverage A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews labels Jan 24, 2023
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews O: testing Objective: aims to improve testing coverage
Projects
Status: 📥 To Do
Development

No branches or pull requests

1 participant