Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define testing strategy #433

Closed
Tracked by #554
plafer opened this issue Feb 15, 2023 · 2 comments
Closed
Tracked by #554

Define testing strategy #433

plafer opened this issue Feb 15, 2023 · 2 comments
Assignees
Labels
O: exploratory Objective: aims to investigate new ideas O: testing Objective: aims to improve testing coverage

Comments

@plafer
Copy link
Contributor

plafer commented Feb 15, 2023

We need to define a testing strategy that will identify what needs to be tested along with how to test it. For example, some questions to answer include

  • Currently MockContext doesn't do proper proofs. Should it? This would involve modifying the store to be a Merkle tree.
  • We want to make sure that we are compatible with gaia. However, integration tests of that sort are very slow, so we probably don't want to run them on every PR. Perhaps before every release is sufficient?
  • What will we be testing with basecoin-rs, that won't be covered with the MockContext-based tests?

Perhaps the outcome of this issue is an ADR which answers all these questions.

@plafer plafer added O: testing Objective: aims to improve testing coverage O: exploratory Objective: aims to investigate new ideas labels Feb 15, 2023
@Farhad-Shabani Farhad-Shabani moved this to 📥 To Do in ibc-rs Feb 15, 2023
@adizere
Copy link
Contributor

adizere commented May 27, 2024

There's an ADR linked from #1109 that closes this issue.

@adizere adizere closed this as completed May 27, 2024
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs May 27, 2024
@adizere
Copy link
Contributor

adizere commented May 27, 2024

We have not answered the third question in the original issue description:

What will we be testing with basecoin-rs, that won't be covered with the MockContext-based tests?

This is subject for future work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: exploratory Objective: aims to investigate new ideas O: testing Objective: aims to improve testing coverage
Projects
Status: Done
Development

No branches or pull requests

3 participants