Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Module in ModuleValidation and ModuleExecution #465

Open
Tracked by #554
plafer opened this issue Feb 23, 2023 · 0 comments
Open
Tracked by #554

Separate Module in ModuleValidation and ModuleExecution #465

plafer opened this issue Feb 23, 2023 · 0 comments
Assignees
Labels
A: breaking Admin: breaking change that may impact operators O: exploratory Objective: aims to investigate new ideas

Comments

@plafer
Copy link
Contributor

plafer commented Feb 23, 2023

Module should be split into 2 different traits:

  • ModuleValidation which contains all *_validate() methods
  • ModuleExecution which contains all *_execute() methods

Modifications to Router:

  • Router::get_route_validation() -> Option<&dyn ModuleValidation>
    • previously Router::get_route()
  • Router::get_route_execution() -> Option<&dyn ModuleExecution>
    • previously Router::get_route_mut
  • Router::has_route() split in has_route_validation() and has_route_execution()
    • we should provide default implementations for these too based on get_route_*()
@plafer plafer added the A: critical Admin: critical or Important label Feb 23, 2023
@plafer plafer added this to the v0.30.0 milestone Feb 23, 2023
@Farhad-Shabani Farhad-Shabani moved this to 🏗️ In Progress in ibc-rs Feb 24, 2023
@Farhad-Shabani Farhad-Shabani added the A: breaking Admin: breaking change that may impact operators label Feb 24, 2023
@Farhad-Shabani Farhad-Shabani modified the milestones: v0.30.0, v0.31.0 Feb 27, 2023
@plafer plafer added O: exploratory Objective: aims to investigate new ideas and removed A: critical Admin: critical or Important labels Feb 27, 2023
@Farhad-Shabani Farhad-Shabani modified the milestones: v0.31.0, v0.32.0 Feb 28, 2023
@Farhad-Shabani Farhad-Shabani modified the milestones: v0.32.0, v0.33.0 Mar 13, 2023
@Farhad-Shabani Farhad-Shabani moved this from 🏗️ In Progress to 📥 To Do in ibc-rs Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: breaking Admin: breaking change that may impact operators O: exploratory Objective: aims to investigate new ideas
Projects
Status: 📥 To Do
Development

Successfully merging a pull request may close this issue.

2 participants