Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Transfer App] Missing token transfer APIs for is_account_blocked and set_port #509

Closed
Farhad-Shabani opened this issue Mar 8, 2023 · 2 comments
Closed

[Transfer App] Missing token transfer APIs for is_account_blocked and set_port #509

Farhad-Shabani opened this issue Mar 8, 2023 · 2 comments
Labels
A: breaking Admin: breaking change that may impact operators A: bug Admin: something isn't working O: reliability Objective: cause to improve trustworthiness and consistent performing

Comments

@Farhad-Shabani
Copy link
Member

Farhad-Shabani commented Mar 8, 2023 •
edited
Loading

Problem Statment

Upon scanning IBC-go, I noticed that two essential APIs were missing from our token transfer context.

  • set_port: We have get_port, but there isn't any interface to set it.

    • Note: we already set the port for MockContext by implementing add_port method on it!

  • is_account_blocked : If the receiver's account is blocked or inactive (which is possible in the Tendermint chain), then we're not validating TransferMsg properly.
@Farhad-Shabani Farhad-Shabani added A: bug Admin: something isn't working A: breaking Admin: breaking change that may impact operators O: reliability Objective: cause to improve trustworthiness and consistent performing labels Mar 8, 2023
@Farhad-Shabani Farhad-Shabani mentioned this issue Mar 8, 2023
Closed
7 tasks
@Farhad-Shabani
Copy link
Member Author

The added send/mint/burn_coins_validate interface through PR #512, would cover the check that was supposed to do by is_account_blocked. Thus, not needed anymore

@Farhad-Shabani
Copy link
Member Author

The issue with get/set_port is connected to a more general problem that surfaced in #519

@github-project-automation github-project-automation bot moved this to ✅ Done in ibc-rs Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: breaking Admin: breaking change that may impact operators A: bug Admin: something isn't working O: reliability Objective: cause to improve trustworthiness and consistent performing
Projects
ibc-rs
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Farhad-Shabani