Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ICS02] Modify MsgUpdateClient handler to also handle misbehaviour due to ibc-proto-rs v0.34.0 updates #835

Closed
Tracked by #554
Farhad-Shabani opened this issue Aug 21, 2023 · 0 comments · Fixed by #1075
Closed
Tracked by #554

[ICS02] Modify MsgUpdateClient handler to also handle misbehaviour due to ibc-proto-rs v0.34.0 updates #835

Farhad-Shabani opened this issue Aug 21, 2023 · 0 comments · Fixed by #1075
Assignees
@seanchen1991
Labels
A: critical Admin: critical or Important
Milestone
0.51.0

Comments

@Farhad-Shabani
Copy link
Member

Problem Statment

v0.34.0 of ibc-proto-rs received an update from ibc-go proto version 7.2.0 which involves a change that renames the header field of the proto MsgUpdateClient to the client_message. As a result, submitting a misbehavior report through MsgUpdateClient is now a legitimate action. However, our MsgUpdateClient handler is originally designed for client updating purposes (e.g. see here), as the UpdateKind is only set to UpdateClient.

To accommodate this and manage misbehavior reports via MsgUpdateClient it's essential to refactor the pertinent sections of the code. Worth noting there is an additional handler for misbehaviors through MsgSubmitMisbehaviour which lives to support hosts on older versions.
@Farhad-Shabani Farhad-Shabani added the A: critical Admin: critical or Important label Aug 21, 2023
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Aug 21, 2023
@Farhad-Shabani Farhad-Shabani mentioned this issue Aug 21, 2023
Merged
7 tasks
@Farhad-Shabani Farhad-Shabani mentioned this issue Nov 29, 2023
Open
@seanchen1991 seanchen1991 mentioned this issue Feb 5, 2024
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Feb 6, 2024
@Farhad-Shabani Farhad-Shabani added this to the 0.51.0 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanchen1991 seanchen1991

Labels
A: critical Admin: critical or Important
Projects
None yet
Milestone
0.51.0
2 participants
@seanchen1991 @Farhad-Shabani