Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase_*_counter methods should return error in case of overflow #857

Closed
Tracked by #861
Farhad-Shabani opened this issue Sep 5, 2023 · 0 comments · Fixed by #858
Closed
Tracked by #861

increase_*_counter methods should return error in case of overflow #857

Farhad-Shabani opened this issue Sep 5, 2023 · 0 comments · Fixed by #858
Assignees
@Farhad-Shabani
Labels
A: breaking Admin: breaking change that may impact operators
Milestone
v0.45.0

Comments

@Farhad-Shabani
Copy link
Member

Summary

In order to allow hosts implementing ExecutionContext to handle overflow cases for increase_*_counter methods, they should return the Result<(),ContextError> type.
@Farhad-Shabani Farhad-Shabani added the A: breaking Admin: breaking change that may impact operators label Sep 5, 2023
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Sep 5, 2023
@Farhad-Shabani Farhad-Shabani changed the title The increase_*_counter methods should return an error in case of overflow increase_*_counter methods should return error in case of overflow Sep 5, 2023
@Farhad-Shabani Farhad-Shabani mentioned this issue Sep 5, 2023
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Sep 5, 2023
@Farhad-Shabani Farhad-Shabani mentioned this issue Sep 7, 2023
Closed
@Farhad-Shabani Farhad-Shabani self-assigned this Sep 7, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.45.0 milestone Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Farhad-Shabani Farhad-Shabani

Labels
A: breaking Admin: breaking change that may impact operators
Projects
ibc-rs
Status: ✅ Done
Milestone
v0.45.0
Development

Successfully merging a pull request may close this issue.

fix(api)!: increase_*_counters methods return Result type cosmos/ibc-rs
1 participant
@Farhad-Shabani